Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DIA-903): One-Shot Facebook Login #11060

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Nov 4, 2024

This PR resolves DIA-903

Description

This PR adds one-shot Facebook Login to Eigen.

iOS Android
https://github.com/user-attachments/assets/465b4696-4c10-43a4-b6a3-d03d7755604d https://github.com/user-attachments/assets/bcc3f997-3670-4e49-a6e3-a137949e700f

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Implemented one-shot facebook login for auth2 - iskounen

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Nov 4, 2024
@iskounen iskounen marked this pull request as draft November 4, 2024 22:37
@iskounen iskounen marked this pull request as ready for review November 5, 2024 16:40
@iskounen iskounen requested a review from araujobarret November 5, 2024 16:40
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Nov 5, 2024

This PR contains the following changes:

  • Dev changes (Implemented one-shot facebook login for auth2 - iskounen - iskounen)

Generated by 🚫 dangerJS against 5d56353

}
tokenForProviderToBeLinked = { idToken, appleUid }

console.log({ navParams, tokenForProviderToBeLinked })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to continue working on this helper when I get to social account linking (it's ticketed), so in the meantime I decided to console log these variables so that I can suppress errors without commenting-out the whole file.

damassi
damassi previously approved these changes Nov 5, 2024
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request to clean up the ;(Foo.bar as jest.Mock).thing() repeat aliasing in tests, but otherwise code looks great 👍

araujobarret
araujobarret previously approved these changes Nov 6, 2024
@iskounen iskounen dismissed stale reviews from araujobarret and damassi via 5d56353 November 6, 2024 10:35
@iskounen iskounen merged commit 044aee2 into main Nov 6, 2024
7 checks passed
@iskounen iskounen deleted the iskounen/feat/one-shot-facebook-login branch November 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants