-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DIA-903): One-Shot Facebook Login #11060
Conversation
} | ||
tokenForProviderToBeLinked = { idToken, appleUid } | ||
|
||
console.log({ navParams, tokenForProviderToBeLinked }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to continue working on this helper when I get to social account linking (it's ticketed), so in the meantime I decided to console log these variables so that I can suppress errors without commenting-out the whole file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request to clean up the ;(Foo.bar as jest.Mock).thing()
repeat aliasing in tests, but otherwise code looks great 👍
This PR resolves DIA-903
Description
This PR adds one-shot Facebook Login to Eigen.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.