-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ONYX-1457): add Create Alert Reminder #11408
Open
dariakoko
wants to merge
25
commits into
main
Choose a base branch
from
dariakoko/ONYX-1457/signal-awareness-and-prominence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(ONYX-1457): add Create Alert Reminder #11408
dariakoko
wants to merge
25
commits into
main
from
dariakoko/ONYX-1457/signal-awareness-and-prominence
+272
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/app/Components/Artist/ArtistArtworks/CreateAlertReminderMessage.tsx
Outdated
Show resolved
Hide resolved
__clearReminderState: Action<this> | ||
} | ||
|
||
export const getCreateAlertReminderModel = (): CreateAlertReminderModel => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the already existing ProgressiveOnboardingModel instead of creating a new model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1457
Description
Original PR: #11346
As agreed on slack, proceed with the variant B option
Show the Reminder:
Track message views
message.Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-08.at.18.38.18.mp4
IMG_7220.MP4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.