Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ONYX-1457): add Create Alert Reminder #11408

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Jan 17, 2025

This PR resolves ONYX-1457

Description

Original PR: #11346
As agreed on slack, proceed with the variant B option

Show the Reminder:

  • after 40 artworks is loaded
  • max 2 times per user
  • the second time the user will see the reminder component will be minimum in 7 days
  • when after seeing the component the user clicks "Create Alert" CTA, the reminder should not be shown again

Track message views

iOS Android
message.Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-08.at.18.38.18.mp4
IMG_7220.MP4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add Create Alert Reminder

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@dariakoko dariakoko self-assigned this Jan 17, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 17, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (add Create Alert Reminder - dariakoko)

Generated by 🚫 dangerJS against a5aeae9

__clearReminderState: Action<this>
}

export const getCreateAlertReminderModel = (): CreateAlertReminderModel => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the already existing ProgressiveOnboardingModel instead of creating a new model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants