Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensures download banner is shown for all users #14894

Conversation

dzucconi
Copy link
Member

The implementation issue stems from enabling page caching, which prevents page pre-fetching in numerous scenarios. Previously, route change completion was only being detected on routes where the loading bar appeared at the top of the screen. In this case, route completion status isn't relevant - we simply need to detect and display based on the number of routes, which is what this implementation now does.

There are two other call sites using this hook that require investigation to determine if additional refactoring opportunities exist.

@dzucconi dzucconi requested a review from a team November 22, 2024 15:00
@dzucconi dzucconi self-assigned this Nov 22, 2024
@dzucconi dzucconi merged commit 67e4117 into main Nov 25, 2024
11 checks passed
@dzucconi dzucconi deleted the DIA-983-investigate-footer-app-download-banner-not-showing-up-for-some-users branch November 25, 2024 12:48
@artsy-peril artsy-peril bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants