fix: ensures download banner is shown for all users #14894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation issue stems from enabling page caching, which prevents page pre-fetching in numerous scenarios. Previously, route change completion was only being detected on routes where the loading bar appeared at the top of the screen. In this case, route completion status isn't relevant - we simply need to detect and display based on the number of routes, which is what this implementation now does.
There are two other call sites using this hook that require investigation to determine if additional refactoring opportunities exist.