feature/GSA_to_Compos

[PeterDebneyOasys]

No description provided.

[PeterDebneyOasys]

This example uses gsapy so is not currently suitable for the non-Arup users

[daviddekoning]

Hi Peter,

I've made a pile of suggestions, which fit into two categories:

1. Making the code more pythonic: this is mostly about how dictionaries are created (using comprehensions instead of looping), and looping directly over data structures instead of looping with an index
2. Helpful functionality in gsapy: gsapy does a lot of work for you, so I've suggested a few ways to avoid re-doing it.

[daviddekoning]

since these are internal to Arup, let's remove them

[PeterDebneyOasys]

done

[daviddekoning]

let's add a note to this initial comment along the lines of If you would like more information about gsapy, please contact Oasys Support

[PeterDebneyOasys]

done

[daviddekoning]

better to simply say GSA('Composite test.gwb') - it will look in the same directory the script is running in

[PeterDebneyOasys]

done

[daviddekoning]

you can replace your for loop with this:

for i in gsa_model._get_entities_in_named_list("Secondary beams"):  # create list of members to be designed
        member = gsa_model.get_members(i)
        member_list.append([i, gsa_model.get_section_info(member.prop),
                            gsa_model.get_member_length(i)])

model._get_entities_in_named_list returns a list of integers (member ids). It works even if the list is 1 to 10 or other complex definitions

gsapy creates a Member object with all the info you need, so there is no need to convert to str and then parse the string.

member.prop is the integer id of the section

[PeterDebneyOasys]

done

[daviddekoning]

from gsapy.modules import Section

sections_dictionary = gsa_model.get(Section)

This creates a dictionary where the keys are the integer ids and the values are Section objects

[daviddekoning]

but I see that you are using the section description as the key, so it needs something different:

sections_dictionary = {s.desc:s for s in gsa_model.get(Section).values}

or

sections_dictionary = {gsa_model.get_section_info(s.index):s for s in gsa_model.get(Section).values}

you could also expand it as

sections = gsa_model.get(Section) # this gives you the basic dict of sections (keys are the index)
sections_dictionary = {gsa_model.get_section_info(s.index) for s in sections}

https://www.geeksforgeeks.org/python-dictionary-comprehension/

[PeterDebneyOasys]

@daviddekoning this option does work

    sections_dictionary = {}
    for i in range(1, 93):  # create sections dictionary:  needs to match model
        sections_dictionary[gsa_model.get_section_info(i)] = i

but is clunky but gives a dictionary in the form {'UB127x76x13':1 etc},

while
sections_dictionary4 = {s.desc:s for s in gsa_model.get(Section).values()}
is elegant but produces something very different.

Is there an elegant way to create the dictionary in the required form?

[daviddekoning]

you could say s.desc.split("%")[2]:s for si in ...., but what I did in my suggested changes is just use the full section name, since they are consistent across GSA and Compos. I just had to replace the %s with spaces:

sections_dictionary = {s.desc.replace("%", " "): i for i, s in sections.items()}

[daviddekoning]

you can iterate over the member list direction here too, and not use an index

[daviddekoning]

no need to re-open if you don't close above

[daviddekoning]

if you make each list item a tuple, you can auto-expand in the last for loop:

compos_results.append((member_name[7:], section))

[daviddekoning]

for member_number, member_section in compos results
    member_new_section = member_section.split()[2]
    ...

[daviddekoning]

with the previous suggestion (line 47), you will have to change this line to

member.prop = new_section.index