-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode method for DiscreteWeibull, LogitNormal, Hypergeometric and SkewNormal #636
Conversation
@rohanbabbar04 These need to be changed if we are opting to send a tuple for multimodal purposes. |
@aloctavodia Issues have been updated for discrete_weibull; I will use minimize_scale from scipy.optimize since direct calculation for mode in discrete_weibull isn't feasible. For the rest, the mode is calculated as provided in Wikipedia or some reliable sources. |
Co-authored-by: Osvaldo A Martin <[email protected]>
@Advaitgaur004 are you still working on this? |
Yes, i am busy for 2 more days, i'll made pr in some time |
great! Thanks |
Changes Made in
|
@Advaitgaur004 check the tests that are failing, you will see linter errors. |
I've finished reviewing the files. Now I see the issue with those three files; I didn't apply the black style, which caused the problem. I have now updated all the files accordingly, and there are no linter errors. |
Description
This PR targeted #604 and work is in progress.
Implemented Modes