This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Cleanup #130
Merged
Cleanup #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2020
TSLint is deprecated, moving to ESLint as modern standard. Read more here: https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md
All of them shouldn't have been there in the first place, all the variables are perfectly defined.
Based on this PR (separate due to conflicts): #108 Includes: - allows passing in the various *ShouldSetResponder props - Exports the types so the consumer has access in their own code - Prefix props/state with ImageZoom* to avoid conflicts with other libraries props and state - Refactor types - Updated README
Added debuggin page to test handlers
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #129 "spring cleanup".
It contains better tooling (ESlint + Prettier 2), minor refactoring and typing fixes.
Also revived demo app.
Feel free to review the code and point out if I've put some bullshit in there accidentally. Although I tested all the things and this repo is quite small, so I'd be surprised if there is any screw-up in there 🙂
I will merge this in a couple of days if there are no comments.
There are couple of things to do though before merging (probably will handle it tomorrow):
I've ingested the following PRs manually due to conflicts and the desire of moving things a bit faster:
PR #108 (Fixes #107, Fixes #94)
PR #127 (Fixes #111)
Sorry for closing your PRs guys, I probably should have started with merging yours. I will make sure to mark your contributions once I have allcontributors bot installed in this repo (can't do it myself, need @ascoders to do it or make it old-fashioned manual way).