Issue# 109 - Added APIs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpamarthi
reviewed
Jan 20, 2025
jpamarthi
reviewed
Jan 20, 2025
src/pycatcher/api_diagnostics.py
Outdated
| # Define the input model using Pydantic | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you please remove these empty spaces if possible?
jpamarthi
reviewed
Jan 20, 2025
src/pycatcher/api_run.py
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| def main(): | |||
| uvicorn.run("src.pycatcher.api_catch:app", host="127.0.0.1", port=8000, reload=True) | |||
| uvicorn.run("src.pycatcher.api_diagnostics:app", host="127.0.0.1", port=8000, reload=True) | |||
There was a problem hiding this comment.
Can we launch both the endpoints in the same IP address?
There was a problem hiding this comment.
Yes, it is possible. But, maybe not the way I coded it. It was hard to test this locally. Nonetheless, I updated api_run.py and changed the code to make sure the port conflict doesn't arise.
jpamarthi
reviewed
Jan 20, 2025
src/pycatcher/api_diagnostics.py
Outdated
| # Define the output model | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also please remove these 2 new lines
|
@aditya566 please merge the new changes from main to your branch |
|
Addressed the comments in this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added APIs in api_diagnostics.py for the following methods:
build_seasonal_plot_classic
build_seasonal_plot_stl
build_seasonal_plot_mstl