Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring more functions in catch.py #112

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Refactoring more functions in catch.py #112

merged 5 commits into from
Jan 20, 2025

Conversation

jpamarthi
Copy link
Collaborator

  1. Bumped the version to 0.0.67
  2. Refactored the functions detect_outliers_stl, detect_outliers_moving_average, calculate_optimal_window_size with right logging and exception handling
  3. Added test cases for the above
  4. Executed the notebook to ensure everything is intact after the changes.

@jpamarthi jpamarthi requested a review from aseemanand as a code owner January 20, 2025 12:42
Copy link
Owner

@aseemanand aseemanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseemanand aseemanand merged commit 8e6e53e into main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants