Refactor code and create methods to expose functionality that can be reused to implement drag and drop in Windows #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reused to implement drag and drop in Windows
martincapello
commented
Apr 11, 2024
| SetClipboardData(png_format, png_handle); | ||
| } | ||
| } | ||
| namespace win { |
There was a problem hiding this comment.
I know we don't need this namespace here and we could move create_img to the other namespace block. I just did this because the code comparison is actually easier when this code is here (when using vscode to compare changes). If you don't see the point in having this, I will be happy to move it.
|
Created by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitmapInfoimplementation from interface, putting code in cpp file and data + methods definitions in header file. It is also moved inside the win namespace. This was needed to be able to reuse theBitmapInfostruct when implementingDragDataProvider::getImage().write_png_on_stream,write_png, andread_pngto cpp file and leaves only definitions on header.create_imgandcreate_dibv5functions which basically contains code copy & pasted from other methods with some slight changes.Note: I've noted that using vscode for comparing differences is better than using the split view on Github, at least for these changes, because it shows a better match between lines of codes on each side.