Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test readability-qualified-auto check #81

Closed
wants to merge 1 commit into from
Closed

Conversation

dacap
Copy link
Member

@dacap dacap commented Feb 27, 2024

No description provided.

@dacap dacap force-pushed the test-pr branch 2 times, most recently from 259578d to be1d948 Compare February 27, 2024 20:53
@dacap dacap force-pushed the test-pr branch 4 times, most recently from a18aeff to 83c6b73 Compare February 27, 2024 21:45
Copy link
Collaborator

@aseprite-bot aseprite-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -39,6 +39,8 @@ void draw_window(os::Window* window)

int app_main(int argc, char* argv[])
{
auto ptr = argv;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'auto ptr' can be declared as 'auto *ptr' [readability-qualified-auto]

Suggested change
auto ptr = argv;
auto *ptr = argv;

@dacap dacap closed this Feb 27, 2024
@dacap dacap deleted the test-pr branch February 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants