This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Fix incorrect regex for amount conversion. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex in Ofx::createAmountFromStr included a "?" after the "mark" whether it be decimal or comma. That "?" made it match number strings regardless of whether they had a "mark" to parse out, and grossly changed their value. This made amounts such as 1000 or -1000 convert to 10 or -10. Removing the conditional after the mark resolved this issue. There are new tests to show that this resolves the issue without breaking others. Resolves asgrim#19
asgrim
reviewed
Jan 17, 2017
| @@ -37,7 +37,12 @@ public function amountConversionProvider() | |||
| '-1.000,00' => ['-1.000,00', -1000.0], | |||
| '1' => ['1', 1.0], | |||
| '10' => ['10', 10.0], | |||
| '100' => ['100', 1.0], // @todo this is weird behaviour, should not really expect this | |||
| '100' => ['100', 100.0], | |||
There was a problem hiding this comment.
Whether right or not, this is a BC break, so targeting this for next major.
asgrim
added
the
enhancement
asgrim
approved these changes
Jan 17, 2017
|
I feel that it's fairly unlikely that many of the users are even aware that they are occasionally getting incorrect results. It would be rather difficult for someone to account for this behavior in their implementation of the library too. Do you have a rough idea of when the next major release will be up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex in Ofx::createAmountFromStr included a "?" after the "mark"
whether it be decimal or comma. That "?" made it match number strings
regardless of whether they had a "mark" to parse out, and grossly
changed their value.
This made amounts such as 1000 or -1000 convert to 10 or -10. Removing
the conditional after the mark resolved this issue. There are new tests
to show that this resolves the issue without breaking others.
Resolves #19