Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chibi test): add a type test for exceptions in test-error #998

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dpk
Copy link
Contributor

@dpk dpk commented Aug 25, 2024

Arguably the name and pred should be independent of one another, but that would require rewriting test-error as an explicit renaming macro in order to be able to type check the name (and assume it must be a string) and thus lose portability.

Copy link
Owner

@ashinn ashinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashinn ashinn merged commit 491cf32 into ashinn:master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants