Check returns true if check succeeded

ashokgelal · Apr 28, 2017 · 46ec4f1 · 46ec4f1
1 parent 121ea93
commit 46ec4f1
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Magpie/Magpie/Services/Magpie.cs b/src/Magpie/Magpie/Services/Magpie.cs
@@ -53,6 +53,7 @@ await Check(AppInfo.AppCastUrl, CheckState.ChannelSwitch, channelId, showDebuggi
         }
 
         private async Task Check(string appcastUrl, CheckState checkState, int channelId = 1, bool showDebuggingWindow = false)
+        private async Task<bool> Check(string appcastUrl, CheckState checkState, int channelId = 1, bool showDebuggingWindow = false)
         {
             _logger.Log(string.Format("Starting fetching remote channel content from address: {0}", appcastUrl));
             try
@@ -64,12 +65,15 @@ private async Task Check(string appcastUrl, CheckState checkState, int channelId
                     {
                         ShowErrorWindow();
                     }
-                    return;
+                    return false;
                 }
 
                 var appcast = ParseAppcast(data);
 
-                if (checkState == CheckState.ChannelSwitch && FailedToEnroll(appcast, channelId)) return;
+                if (checkState == CheckState.ChannelSwitch && FailedToEnroll(appcast, channelId))
+                {
+                    return false;
+                }
 
                 var channelToUpdateFrom = BestChannelFinder.Find(channelId, appcast.Channels);
 
@@ -83,10 +87,12 @@ private async Task Check(string appcastUrl, CheckState checkState, int channelId
                     ShowNoUpdatesWindow();
                 }
                 AppInfo.SubscribedChannel = channelId;
+                return true;
             }
             catch (Exception ex)
             {
                 _logger.Log(string.Format("Error parsing remote channel: {0}", ex.Message));
+                return false;
             }
             finally
             {