Fix: NULL-terminating path

ashvardanian · Mar 18, 2024 · 7c910bf · 7c910bf
1 parent f35793a
commit 7c910bf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -518,7 +518,7 @@ The `Str` class has `write_to` to write the string to a file, and `offset_within
 web_archieve = Str("<html>...</html><html>...</html>")
 _, end_tag, next_doc = web_archieve.partition("</html>") # or use `find`
 next_doc_offset = next_doc.offset_within(web_archieve)
-web_archieve.write_to("next_doc.html")
+web_archieve.write_to("next_doc.html") # no GIL, no copies, just a view
 ```
 
 #### PyArrow

diff --git a/python/lib.c b/python/lib.c
@@ -1271,6 +1271,7 @@ static PyObject *Str_write_to(PyObject *self, PyObject *args, PyObject *kwargs)
         return NULL;
     }
     memcpy(path_buffer, path.start, path.length);
+    path_buffer[path.length] = '\0';
 
     // Unlock the Global Interpreter Lock (GIL) to allow other threads to run
     // while the current thread is waiting for the file to be written.

diff --git a/scripts/test.py b/scripts/test.py
@@ -108,7 +108,7 @@ def test_unit_buffer_protocol():
 
 def test_str_write_to():
     native = "line1\nline2\nline3"
-    big = Str(native)  # Assuming Str is your custom class
+    big = Str(native)
 
     # Create a temporary file
     with tempfile.NamedTemporaryFile(delete=False) as tmpfile: