calc_error_radius is an overly complex and unnecessary calculation

[ddobie]

vast-pipeline/vast_pipeline/image/utils.py

Line 43 in 328e7a5

def calc_error_radius(ra, ra_err, dec, dec_err) -> float:

From a discussion with @mauch: The function seems to be doing calculations that make sense if your uncertainties are in image coordinates, not celestial. The numbers it produces are not correct for celestial coordinates in general. The correct calculation should be much simpler - just take the max of the ra and dec errors

[mauch]

Actually, upon further thought after our discussion - I realised the equivalent calculation would be to take sqrt(ra_err^2 + dec_err^2) since the calc_error_radius function is computing the vertices of a box surrounding the error ellipse rather than the edges.