Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error_ellipse calculation. #792

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

mauch
Copy link
Contributor

@mauch mauch commented Nov 22, 2024

Quick fix for #790

@mauch mauch added the bug Something isn't working label Nov 22, 2024
@mauch
Copy link
Contributor Author

mauch commented Nov 25, 2024

I suspect - but am not 100% certain that this also might help with #704 since I noticed that the (no longer used) calc_error_ellipse function was returning 0 for the error when the input values were very small - the change to np.hypot avoids this problem.

@mauch mauch requested a review from ddobie November 25, 2024 05:10
@mauch
Copy link
Contributor Author

mauch commented Nov 25, 2024

Should probably make this a V2 change...

@mauch mauch added the do not merge Do not merge this PR label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do not merge Do not merge this PR
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant