Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise forced photometry #788

Merged
merged 14 commits into from
Nov 23, 2024
Merged

Optimise forced photometry #788

merged 14 commits into from
Nov 23, 2024

Conversation

ddobie
Copy link
Contributor

@ddobie ddobie commented Nov 22, 2024 •
edited
Loading

  • Reorder some calculations and drop sources ASAP to minimise the number of sources that are being concatenated and merged
  • Add option to turn off clustering (set cluster_threshold=0)
  • Add numba as a conditional dependency
  • Where possible, use forced_phot v2, which speeds up forced photometry extraction substantially using numba

@ddobie ddobie marked this pull request as ready for review November 22, 2024 05:29
@ddobie ddobie requested a review from mauch November 22, 2024 05:29
mauch
mauch approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@mauch mauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ddobie ddobie merged commit 6e497ab into dev Nov 23, 2024
5 checks passed
@ddobie ddobie deleted the upgrade-forced-phot branch November 23, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauch mauch mauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddobie @mauch