-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the measurements creation to use parquet/dask rather than arrow/vaex files #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files (e.g. images)
…-pipeline into v2-measurements-creation
mauch
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor typos and a suggestion to make a separate function to delete files or directories.
Co-authored-by: Tom Mauch <[email protected]>
Co-authored-by: Tom Mauch <[email protected]>
I've implemented the suggested changes. Also fixed a few minor bugs and warnings that I hadn't picked up the first time I tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
Notes:
The log files aren't displaying properly in the web interface. The interface can find the files, but not display them, e.g.
I realised that the measurement pairs parquet files don't need to be generated (in fact doing so breaks everything because they already exist). So there's a few changes that need to be made to the code (mostly done) and the nomenclature ("Generate parquet files" -> "Generate measurements parquet")
Screenshots that need updating:
Other things to update