Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of cutouts (always calculate normalisations, adjust figure size dynamically) #581

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Improve handling of cutouts (always calculate normalisations, adjust figure size dynamically) #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
691c8f9
Improve normalisation handling
ddobie Jan 9, 2025
6fbc084
Update source logger to include source name
ddobie Jan 9, 2025
a7df8b6
Make show_all_png_cutouts figure size dynamic
ddobie Jan 9, 2025
84e4f88
Improve variable naming: force -> force_cutout_fetch
ddobie Jan 9, 2025
da1ab73
Fix indent
ddobie Jan 9, 2025
31b97a3
PEP8
ddobie Jan 9, 2025
09d5b3c
Updated changelog
ddobie Jan 9, 2025
25d5075
Force pytest to use python 3.8.12, as this works in the vast-pipeline…
ddobie Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python_version: ['3.8', '3.9', '3.10']
python_version: ['3.8.12', '3.9', '3.10']

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

#### Changed

- Calculate cutout normalisation each time, rather than storing a normalisation with no easy way to change it [#581](https://github.com/askap-vast/vast-tools/pull/581/)
- Renamed "force" variable to "force_cutout_fetch" for clarity [#581](https://github.com/askap-vast/vast-tools/pull/581/)
- Allow users to specify the size of a single cutout in show_all_png_cutouts, rather than forcing them to specify the total figure size [#581](https://github.com/askap-vast/vast-tools/pull/581/)
- Updated vasttools.source.Source logger to include the source name [#581](https://github.com/askap-vast/vast-tools/pull/581/)
- Minor changes to docstring formatting throughout based on updated mkdocs versions [#334](https://github.com/askap-vast/vast-tools/pull/334)
- Minor changes for matplotlib 3.7: add angle kwarg to Ellipse and change matplotlib.pyplot.cm.get_cmap to matplotlib.colormaps.get_cmap [#334](https://github.com/askap-vast/vast-tools/pull/334)
- Refreshed dependencies - major changes are python 3.10, mkdocs (and related packages), astropy v5 and matplotlib v3.7 [#334](https://github.com/askap-vast/vast-tools/pull/334)
Expand All @@ -38,7 +42,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Removed lightgallery functionality from docs [#334](https://github.com/askap-vast/vast-tools/pull/334)

#### List of PRs

- [#581](https://github.com/askap-vast/vast-tools/pull/581/): feat: Improve source cutout handling and other minor changes
- [#576](https://github.com/askap-vast/vast-tools/pull/576): feat: Add epoch 69
- [#575](https://github.com/askap-vast/vast-tools/pull/575): feat: Add epoch 68
- [#573](https://github.com/askap-vast/vast-tools/pull/573): feat: Add epoch 67
Expand Down
Loading
Loading