Fix TestSuiteResolver parse path containing "@" symbol #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263.
The
TestSuiteResolver.parsemethod fails when an "@" symbol is in the path. This is because it splits the script's path on "@" to retrieve test ID without accounting for other "@" symbols elsewhere in the path. I have fixed this by usingjava.nio.file.Pathsto split the file name from the base path and check only the file name for an "@" symbol.Let me know if the addition of a unit test case for this would be useful (e.g. to test the case where
scriptscontains a path with an "@" symbol).