Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vue example redirect #284

Merged
merged 1 commit into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ jobs:
- 'react-cra'
- 'rules_nodejs_to_rules_js_migration'
- 'ts_project_transpiler'
- 'vue'
- 'write_source_files'

steps:
Expand Down
1 change: 0 additions & 1 deletion vue/.aspect/bazelrc/.gitignore

This file was deleted.

15 changes: 0 additions & 15 deletions vue/.aspect/bazelrc/BUILD.bazel

This file was deleted.

15 changes: 0 additions & 15 deletions vue/.aspect/bazelrc/bazel6.bazelrc

This file was deleted.

28 changes: 0 additions & 28 deletions vue/.aspect/bazelrc/convenience.bazelrc

This file was deleted.

62 changes: 0 additions & 62 deletions vue/.aspect/bazelrc/correctness.bazelrc

This file was deleted.

19 changes: 0 additions & 19 deletions vue/.aspect/bazelrc/debug.bazelrc

This file was deleted.

28 changes: 0 additions & 28 deletions vue/.aspect/bazelrc/javascript.bazelrc

This file was deleted.

38 changes: 0 additions & 38 deletions vue/.aspect/bazelrc/performance.bazelrc

This file was deleted.

2 changes: 0 additions & 2 deletions vue/.bazelignore

This file was deleted.

1 change: 0 additions & 1 deletion vue/.bazeliskrc

This file was deleted.

26 changes: 0 additions & 26 deletions vue/.bazelrc

This file was deleted.

1 change: 0 additions & 1 deletion vue/.bazelversion

This file was deleted.

29 changes: 0 additions & 29 deletions vue/.gitignore

This file was deleted.

6 changes: 0 additions & 6 deletions vue/.npmrc

This file was deleted.

3 changes: 0 additions & 3 deletions vue/.vscode/extensions.json

This file was deleted.

56 changes: 0 additions & 56 deletions vue/BUILD.bazel

This file was deleted.

15 changes: 0 additions & 15 deletions vue/MODULE.bazel

This file was deleted.

24 changes: 2 additions & 22 deletions vue/README.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,4 @@
# vue-project

Created by running `npm init vue@latest` following https://vuejs.org/guide/quick-start.html#local

Then adding Bazel configuration files.

Install local tooling: `npx pnpm i`

Devmode: `npm run dev`

Typecheck and build: `npm run build`

Note: this project simply wraps the Vite build system with Bazel.
This doesn't provide any incrementality benefits of Bazel, because it just runs a single action
when any file changes, which calls through to Vite.
Furthermore we didn't teach Vite the ["ibazel_notify_changes protocol"](https://github.com/bazelbuild/bazel-watcher#running-a-target) so every time the code changes, the devserver restarts from scratch.

However, Vite is a lot faster than Webpack, so at a small scale like this, this developer roundtrip is actually fine.

Also, we show how to extract vue components as pre-built npm packages, using our pnpm workspaces support to link these into an app.
See the `libraries/` folder and the `pnpm-workspace.yaml` file.
This makes the build more incremental since those packages ("component libraries") are not be re-built every time.

To scale up the example further, and to be more Bazel-idiomatic, the Vite composition of tools like `esbuild` and plugins like `@vitejs/plugin-vue` could be decomposed into an analogous Bazel pipeline.
MOVED: this example is now located at
<https://github.com/bazelbuild/examples/tree/main/frontend/vue>
Loading
Loading