Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default cacheDirectory to TEST_TMPDIR #231

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

sallustfire
Copy link
Contributor

See #230


Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Suggested release notes are provided below:

Now cacheDirector is set to TEST_TMPDIR by default to improve test isolation and cleanup.

Test plan

  • This change is foundational and affects every test in the codebase. Existing tests confirm this doesn't introduce a regression.
  • It doesn't appear to be possible to determine the cacheDirectory from within a jest test suite. However, an e2e test is added that explicitly sets --test_tmpdir and confirms that jest produced outputs in that folder indicating that it was successfully passed through the config chain.
  • The case where user configuration specifies cacheDirectory via config is currently untested. It is unclear if that should even be allowed since --no-cache is forced and the location of the --cacheDirectory is otherwise an implementation detail of the rules.

@gregmagolan
Copy link
Member

See https://bazelbuild.slack.com/archives/C04281DTLH0/p1706234301711269 for more context around this change.

@gregmagolan gregmagolan merged commit 428b2da into aspect-build:main Jan 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants