Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
JesseTatasciore committed Aug 29, 2024
1 parent 929ecab commit 50b5bab
Show file tree
Hide file tree
Showing 8 changed files with 114 additions and 113 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ npm/private/test/package.json=600650131
npm/private/test/vendored/is-odd/package.json=1041695223
npm/private/test/vendored/lodash-4.17.21.tgz=-1206623349
npm/private/test/vendored/semver-max/package.json=578664053
package.json=-1731204043
pnpm-lock.yaml=1968454333
package.json=-1383527523
pnpm-lock.yaml=-203099915
pnpm-workspace.yaml=-762451270
4 changes: 2 additions & 2 deletions .bazeliskrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
USE_BAZEL_VERSION=aspect/5.9.25
BAZELISK_BASE_URL=https://s3.us-east-2.amazonaws.com/aspect-static-dev/aspect
USE_BAZEL_VERSION=aspect/2024.35.35
23 changes: 4 additions & 19 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,32 +1,17 @@
// @ts-check

// @ts-ignore
import babelParser from '@babel/eslint-parser';
import importAssertPlugin from '@babel/plugin-syntax-import-assertions';
import eslint from '@eslint/js';
import cypressPlugin from 'eslint-plugin-cypress';
import mochaPlugin from 'eslint-plugin-mocha';
import hooksPlugin from 'eslint-plugin-react-hooks';
import js from "@eslint/js";
import simpleImportSort from 'eslint-plugin-simple-import-sort';
import unusedImports from 'eslint-plugin-unused-imports';
import globals from 'globals';
import tseslint from 'typescript-eslint';

const todo_promoteToError = 'warn';

export default tseslint.config(
eslint.configs.recommended,
export default [
js.configs.recommended,
// Awkward setup; see https://github.com/facebook/react/issues/28313
{
plugins: {
// @ts-ignore
'react-hooks': hooksPlugin,
'simple-import-sort': simpleImportSort,
'unused-imports': unusedImports,
},
rules: {
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',
'simple-import-sort/imports': 'error',
'simple-import-sort/exports': 'error',
'unused-imports/no-unused-imports': 'error',
Expand All @@ -40,4 +25,4 @@ export default tseslint.config(
},
},
},
);
];
1 change: 1 addition & 0 deletions foo.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
13 changes: 10 additions & 3 deletions js/private/dev_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,18 @@ def rules_js_dev_dependencies():
urls = ["http://github.com/keith/buildifier-prebuilt/archive/6.4.0.tar.gz"],
)

# http_archive(
# name = "aspect_rules_lint",
# sha256 = "6e32df708b40ea8c6d4482eeaf8fd6afaa8798d0028654ba25b667b5aee5707c",
# strip_prefix = "rules_lint-0.7.0",
# url = "https://github.com/aspect-build/rules_lint/releases/download/v0.7.0/rules_lint-v0.7.0.tar.gz",
# )

http_archive(
name = "aspect_rules_lint",
sha256 = "6e32df708b40ea8c6d4482eeaf8fd6afaa8798d0028654ba25b667b5aee5707c",
strip_prefix = "rules_lint-0.7.0",
url = "https://github.com/aspect-build/rules_lint/releases/download/v0.7.0/rules_lint-v0.7.0.tar.gz",
sha256 = "2f6ddca7a15bd6612f70d465fc68f6e1452436b57f4b6b98693c5828f2d6dffd",
strip_prefix = "rules_lint-1.0.0-rc9",
url = "https://github.com/aspect-build/rules_lint/releases/download/v1.0.0-rc9/rules_lint-v1.0.0-rc9.tar.gz",
)

http_archive(
Expand Down
2 changes: 1 addition & 1 deletion js/private/test/data/test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const dataPath = process.argv[2] || './data.json'

const { answer } = require(dataPath)
let { answer } = require(dataPath)

if (answer !== 42) {
throw new Error(`The answer (${answer}) is not 42!`)
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"devDependencies": {
"@eslint/js": "9.9.1",
"@eslint/js": "8.57.0",
"@types/node": "16.18.11",
"chalk": "5.1.1",
"eslint": "9.9.1",
"eslint": "8.57.0",
"prettier": "3.3.3",
"prettier-plugin-sh": "0.14.0",
"eslint-plugin-simple-import-sort": "12.1.1",
Expand Down
Loading

0 comments on commit 50b5bab

Please sign in to comment.