Skip to content

Commit

Permalink
docs: document exclude_types_from_npm_packages as deprecated
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard committed Nov 7, 2024
1 parent a829760 commit db066ec
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions docs/npm_package.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions npm/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ exports_files(

# Allows for faster dev roundtrip by excluding type-checking from libraries that are
# internally used via npm_package
# TODO(3.0): remove
bool_flag(
name = "exclude_types_from_npm_packages",
build_setting_default = False,
visibility = ["//visibility:public"],
)

# TODO(3.0): remove
config_setting(
name = "exclude_types_from_npm_packages_flag",
flag_values = {":exclude_types_from_npm_packages": "true"},
Expand Down
2 changes: 0 additions & 2 deletions npm/private/npm_package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,6 @@ def npm_package(
The two `include*_types` options may cause type-check actions to run, which slows down your
development round-trip.
You can pass the Bazel option `--@aspect_rules_js//npm:exclude_types_from_npm_packages`
to override these two attributes for an individual `bazel` invocation, avoiding the type-check.
As of rules_js 2.0, the recommended solution for avoiding eager type-checking when linking
1p deps is to link `js_library` or any `JsInfo` producing targets directly without the
Expand Down

0 comments on commit db066ec

Please sign in to comment.