Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: demonstrate dev dependencies between workspace projects #2056

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 4, 2025

This shows how the lockfile dev flag is only set if all uses of that package are dev-only. Adding a single non-dev dependency on a package such as this example makes that flag disappear and has incorrect side-effects causing issues such as #2013.

This does not add any failing tests at this time but I'd like to merge the additional test changes here for now.


Changes are visible to end-users: no

Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Jan 4, 2025

Test

All tests were cache hits

212 tests (100.0%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 172ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 97ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 22ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 162ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 93ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 362ms.


Test

e2e/pnpm_lockfiles

4 test targets passed

Targets
//v54:repos_0_test [k8-fastbuild]38ms
//v60:repos_0_test [k8-fastbuild]30ms
//v61:repos_0_test [k8-fastbuild]36ms
//v90:repos_0_test [k8-fastbuild]41ms

Total test execution time was 145ms. 38 tests (90.5%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 1s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 115ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 116ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.


Buildifier      Format

@jbedard jbedard force-pushed the pnpm-dev-flag branch 2 times, most recently from fe3ea27 to cf3f12a Compare January 5, 2025 00:00
@jbedard jbedard marked this pull request as ready for review January 5, 2025 00:04
@jbedard jbedard enabled auto-merge (rebase) January 12, 2025 01:57
@jbedard jbedard merged commit 1686081 into aspect-build:main Jan 12, 2025
96 checks passed
@jbedard jbedard deleted the pnpm-dev-flag branch January 12, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants