-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding clarifications to the contributor agreement and fixing typos #14
base: main
Are you sure you want to change the base?
Conversation
CONTRIBUTING.md
Outdated
|
||
* When you contribute code, you still own the code, but we are free to use it forever. | ||
* Contributing code to the project does not automatically mean that the end product will be suitable for a particular purpose you may have. | ||
* If your contribution causes us harm, and you could have prevented it, you are responsible for the harm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting one. I wonder if people will take on such a burden. One way to prevent the harm is not to contribute. But it's clear at least, and that I appreciate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pretty standard clause. I could modify it to specify what we're targeting here is intellectual property violations that you could have, and should have avoided. That's what the actual legalese says and I could express that kind of limit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please. If someone leaves a project can they be retroactively liable too? Is there such a thing as open source contributors insurance?
CONTRIBUTING.md
Outdated
* When you contribute code, you still own the code, but we are free to use it forever. | ||
* Contributing code to the project does not automatically mean that the end product will be suitable for a particular purpose you may have. | ||
* If your contribution causes us harm, and you could have prevented it, you are responsible for the harm. | ||
* We only allow copyleft (GPL) licensed libraries to be used in our copyleft-licensed projects. We don't allow copyleft licenses in non-copyleft projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So no other copy left licenses will be allowed other than GPL and its variants? Is MIT allowed?
I think it should be made clearer what copyleft licenses are. And what is not a copyleft license with examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPL was meant as an example, not as an exhaustive list. I'll further clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify copyleft please. It's jargon and not plain language.
Looks aces to me, most of these are tacit assumptions in the FOSS world, but alas there's a reason it's called "common law" and not "common sense" 🤪 The technical portions about coding standards are the only parts I'd still care to edit, but that should happen in another PR, keeping this one focused on explaining the legalese. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo but otherwise is really clear. Thanks for putting this together to accompany the legal language!
Co-authored-by: Colin Stewart <[email protected]> Signed-off-by: Alex Sirota <[email protected]>
Pull Request
What changed?
I clarified the legal terms in plain English, and fixed a couple typos. I also clarified (but did not change the meaning of) the section on copyleft licenses and non-copyleft repositoriies/projects.
Why did it change?
I was asked to create a plain-English reading of the legal terms. Also, there were a few things that needed improvement/clarification and a couple typos that needed fixing.
Did you fix any specific issues?
None.
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.