Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added License File #119

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Added License File #119

merged 2 commits into from
Nov 5, 2024

Conversation

namithj
Copy link
Contributor

@namithj namithj commented Nov 4, 2024

Added License File

Pull Request

What changed?

Added License File

Why did it change?

Added License File

Did you fix any specific issues?

#68

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

Added License File
@namithj namithj requested a review from a team November 4, 2024 17:40
@asirota
Copy link
Member

asirota commented Nov 4, 2024

Just confirming is this the license you used

https://www.gnu.org/licenses/old-licenses/gpl-2.0.html

@namithj
Copy link
Contributor Author

namithj commented Nov 4, 2024

I used the file that's autogenerated by GitHub when we select license as GPLv2. It should be the same file. Hold the PR, I will do a local diff and confirm as the file is too long to figure out if something is different manually.

@asirota asirota self-assigned this Nov 5, 2024
@asirota asirota added the documentation Improvements or additions to documentation label Nov 5, 2024
@asirota asirota added this to the Phase 1 milestone Nov 5, 2024
1) Uses latest copy of GPL License from gnu.org which replaces the physical address of organization with the we address
2) Updates all references of GPL within the plugin to GPLv2
@namithj
Copy link
Contributor Author

namithj commented Nov 5, 2024

This is good to go. All references of GPL updated to GPLv2. License file is also updated.

Copy link
Member

@asirota asirota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coding standards checks are pretty specific -- good to start fixing these as we go forward, these are not major, but let's fix as we go if we can.

@asirota asirota merged commit 6df35b5 into aspirepress:main Nov 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants