Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update German po file with new translations #153

Closed
wants to merge 2 commits into from

Conversation

asirota
Copy link
Member

@asirota asirota commented Nov 7, 2024

Pull Request

What changed?

last change from @harikrishnanr994 PR to update german translations

Why did it change?

some updates needed to be made to po file

Did you fix any specific issues?

#146 can be closed after this is done

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

@asirota asirota added the i18n Internationalization & Localization label Nov 7, 2024
@asirota asirota added this to the Phase 1 milestone Nov 7, 2024
@asirota asirota requested a review from ipajen November 7, 2024 18:02
@asirota asirota self-assigned this Nov 7, 2024
@namithj namithj requested review from namithj and removed request for namithj November 8, 2024 09:55
@richardkorthuis
Copy link
Contributor

Shouldn't the .mo and .l10n.php files also be updated?

@asirota
Copy link
Member Author

asirota commented Nov 13, 2024

@namithj here is an example where a developer is updating one file but should update others. A glotpress install would enforce the standards that we easily cannot.

@namithj
Copy link
Contributor

namithj commented Nov 13, 2024

I am fine with gloat-press, my problem is with pushing files behind the scene automatically. I don't want to wake up one day and find that an automated language push which failed has messed up the whole site.

@afragen
Copy link
Contributor

afragen commented Nov 13, 2024

@richardkorthuis I believe we're trying to make this better for translators by using GlotPress.

https://aspirepress.slack.com/archives/C0805EY73LG/p1731360485890179

Register at the site and let me know if you want to be a validator for the language.

I'll take care of the other files.

@asirota
Copy link
Member Author

asirota commented Nov 13, 2024

I'm going to close this PR, pending the new translate.aspirepress.org infrastructure being setup. The changes can be submitted there.

@asirota asirota closed this Nov 13, 2024
@asirota asirota deleted the harikrishnanr994-main branch November 13, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization & Localization
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants