Add decouple language packs #209
Open
+1,511
−1,228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#178) Moved translations into separate repo and using git updater code to load translations off github repo translations. --------- Signed-off-by: Andy Fragen <[email protected]>
* update mixed case textdomain to lowercase of aspireupdate references * rename `AspireUpdate` repository to `aspireupdate` * change text domain header * add composer script to more easily create POT file * requires WP-CLI installed locally Signed-off-by: Andy Fragen <[email protected]>
* update afragen/translations-updater with error caching/logging * fix return of false due to validation failure * return WP_Error instead of false * better error handling * updates to afragen/translations-updater * composer update * update error log messaging * update library
|
You should be able to use Git Updater to switch branches for testing. When you're done testing simply switch branches back to Translation updates should occur just as they do for a normal WP installation for translations from .org. You will see a Translations button in Please leave testing comments here or in #208 |
afragen
requested review from
ipajen,
asirota,
toderash,
namithj,
costdev and
sarah-savage
costdev
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Merge branch
translationsintomain.Changes to allow for decoupled language pack updates allowing for plugin release to be separated from translation releases.
Why did it change?
Allows for different release workflows for the plugin and the translations.
Did you fix any specific issues?
Fixes #208
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.