-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the new building DSM class #480
base: main
Are you sure you want to change the base?
Conversation
-add buildiong class -modify DSM naive bidding strategy -refactor function and move common functions to DSMFlex -add tests for the building class -some code refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 78.01% 78.71% +0.69%
==========================================
Files 50 51 +1
Lines 6938 7027 +89
==========================================
+ Hits 5413 5531 +118
+ Misses 1525 1496 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
-improve docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@HafnerMichael there was a small mistake on your branch in the sell_to_market constraints, please compare your working branch with this one to fix the issue since it can affect your results, if you are using that feature |
Ok, no I dont use it there but thanks for the reminder! |
@nick-harder I added a small example (example_01h) |
…o add_building_class
@nick-harder The building class is all set to deploy. We just need to fix an issue related to fast_pandas in the test_building. Could you please check if you have an easy and quick fix for the error related to the FastIndex? |
-fix building tests and add new tests -improve docstrings for dsm class functions -fix building constraints for energy balance -remove unused examples
-fix naive DSM strategy
-remove unused files
Pull Request
Related Issue
Closes #454
Description
-This add a Building DSM class and combines all residential components into one class by @HafnerMichael.
Changes Proposed
Testing
[Describe the testing you've done, including any specific test cases or scenarios]
Checklist
Please check all applicable items:
doc
folder updates)pyproject.toml
doc/release_notes.rst
of the upcoming release is includedAdditional Notes (if applicable)
[Any additional information, concerns, or areas you want reviewers to focus on]
Screenshots (if applicable)
[Add screenshots to demonstrate visual changes]