Add e2e tests #88
Add e2e tests #88
Conversation
osmanhadzic
force-pushed
the
end2endtests
branch
from
c398cfa
to
bdbb2d0
Compare
DeviceSDK/src/main/java/org/astarteplatform/devicesdk/AstartePairingService.java
Outdated
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericMockDevice.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericMockDevice.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,10 @@ | |||
| package org.astarteplatform.devicesdk.tests.e2etest.utilities; | |||
There was a problem hiding this comment.
Do you really need this interface and GenericDeviceMockDataFactory class? I think you can use GenericDeviceSingleton directly, for e2etest, it is a simple use case for testing.
There was a problem hiding this comment.
My factory pattern is for call mock data and a singleton class, which I think is an easy way to read the code.
Signed-off-by: Osman Hadzic <[email protected]>
osmanhadzic
force-pushed
the
end2endtests
branch
from
bdbb2d0
to
d90cd84
Compare
| interfaceServerData = "org.astarte-platform.java.e2etest.ServerDatastream"; | ||
| interfaceDeviceData = "org.astarte-platform.java.e2etest.DeviceDatastream"; | ||
| interfaceServerAggr = "org.astarte-platform.java.e2etest.ServerAggregate"; | ||
| interfaceDeviceAggr = "org.astarte-platform.java.e2etest.DeviceAggregate"; | ||
| interfaceServerProp = "org.astarte-platform.java.e2etest.ServerProperty"; | ||
| interfaceDeviceProp = "org.astarte-platform.java.e2etest.DeviceProperty"; |
There was a problem hiding this comment.
Could these interface names be static final variables ?
I would also check other fields that could be made static and constant, it's cleaner in my opinion and this will make for a lighter constructor.
| mockDevice.getInterfaceDeviceAggr(), | ||
| mockDevice.getInterfaceDeviceData(), | ||
| mockDevice.getInterfaceDeviceProp(), | ||
| mockDevice.getInterfaceServerAggr(), | ||
| mockDevice.getInterfaceServerData(), | ||
| mockDevice.getInterfaceServerProp() |
There was a problem hiding this comment.
In my opinion you should rename this class, currently it's called GenericInterfaceProvider but it has hardcoded interfaces for a specific device.
The better alternative imho would be to have the interfaces list initialized in the constructor and store this generic interface provider inside GenericMockDevice, from what I've seen of the code it shouldn't be a problem and would separate concerns better.
| return new JSONObject(0); | ||
| } | ||
|
|
||
| public void postServerInterface(String interfaces, String endpoint, Object payload) |
There was a problem hiding this comment.
Usually we use different terms, what do you think about renaming the function parameters to postServerInterface(String interface, String path, Object payload) ? I would also rename the arguments of the other methods of this class by following this convention.
|
|
||
| import org.astarteplatform.devicesdk.AstarteDevice; | ||
|
|
||
| public class GenericDeviceMockDataFactory implements GenericDeviceMockData { |
There was a problem hiding this comment.
Since you only have one implementation of this class you could just avoid the interface and keep this class with static methods that return the fields you need. But since the interface got used pretty heavily throughout the code you can also choose to keep it.
Add end-to-end test for:
Send property from device to server and from server to device
Send Datastream from device to server and from server to device
Send Aggregate data from device to server and from server to device
Closes: #54