Preserve br tag in ttml #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhanNguyen700
force-pushed
the
fix-br-tag-is-not-preserved
branch
from
61fc9b9 to
e403fea
Compare
|
hi @asticode , can you have a look? |
asticode
requested changes
Jun 14, 2024
asticode
requested changes
Jun 17, 2024
NhanNguyen700
force-pushed
the
fix-br-tag-is-not-preserved
branch
from
2f60105 to
948d0de
Compare
|
Thanks for the PR, let me know whether you need a tag 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is the PR to fix the issue #77, because of the library structure and xml unmarshaller of golang, this is the best I can do without breaking anything. Please raise your idea if any, I cannot give any other better one.