[ttml] Rename ttml decoder to token reader and correct test data #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No worries 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
My apologize, after changing the token reader to decoder, the code does not work as expected. Or we can say that the polymorphism of Golang is not like what we have in C++, Java, etc, there is no parent and child object so I miss-understood that it will work as expected. I need to wash my brain after years of coding in traditional polymophism. And, with some coincidence, I let vscode extension to automatically edit the input ttml, that extension added some more newlines character and make the output is pretty normal to me and I am blind. My carelessness 🙇