-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SRT styling and bold/underline in VTT #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also fix webvtt tests and add srt/webvtt tests for bold/italic/underline/color?
You can either directly use testdata/example-in.srt
in TestSRT
for instance, or write a new test specifically for html tags.
Could you remove the SSA-related commits from this PR? I don't want to mix different things in the same PR. Thanks |
I done nothing to SSA, its for supporting SRT position tags which use ASS tags so figured its easier to call em that. TBH im not sure what tags most players support, but position is pretty popular. |
OK, then could you remove the 2 commits handling ASS tags from this PR? I'd rather have this change in a separate PR. Thanks! |
Sure will do that. |
It's been over a year, let me know whether this PR is still active 👍 |
No clue, I got busy with life, so idk what happened here since, whether its still relevant. |
No worries, thanks again ❤️ |
Hows this code looking like? Feedback appreciated.