Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQUI and Allowing Customized Colors #45

Open
the-m4a opened this issue May 4, 2021 · 1 comment
Open

CQUI and Allowing Customized Colors #45

the-m4a opened this issue May 4, 2021 · 1 comment

Comments

@the-m4a
Copy link

the-m4a commented May 4, 2021

Hey @astog - I have been doing a good chunk of the work in the past year or so on CQUI (https://github.com/civfanatics/CQUI_Community-Edition) and I wanted to run a few things by you:

  1. I just wanted to re-confirm that it's OK that CQUI integrates the MoreLenses mod? Judging by the comment on your Steam Workshop page, I am assuming it's still OK, however as I have been the primary CQUI contributor for a while now and hadn't updated the ML code in any significant way... I wanted to verify. Also, I'll admit: I just posted a PR that included updating the CQUI integrated ML and thought to myself "I think it better if I verify. :)"

  2. One of the occasional requests on the workshop discussion has been to allow changing of lens colors, and is something that I've wanted to look into for a while, because it sounded like an interesting challenge and always wanted a "softer" pink for the resource highlights. I have been poking at this the last few nights and got to thinking once I saw you'd added a settings panel that if I manage to get something together, I'd like to share it for you to integrate into the MoreLenses mod if you were interested.

This is early prototype - at the moment most of my effort is tied to trying to work with these controls. There was some changes I made to the ModLens_Builder file to make this work, but not a significant overhaul.
img

@the-m4a
Copy link
Author

the-m4a commented May 14, 2021

On item 2: I have a draft PR for CQUI going on so I can track the changes. Did some element renaming for consistency so some common code could be used to retrieve the settings and whatnot. PRs with lots of changes are not fun so I'd create a PR here in smaller pieces
civfanatics/CQUI_Community-Edition#300

WIP:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant