Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Color for Lenses (from CQUI) #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

the-m4a
Copy link

@the-m4a the-m4a commented May 27, 2021

I mentioned in #45 - I had enough requests and personal interest in this kind of thing with CQUI that I wanted to give it a shot. And because it built off of your work with ML, I wanted to also share the changes if you were interested in incorporating that functionality into ML. Pictures/gifs below.

Notes on the Code Changes:

  • By and large this is the same logic that I put into CQUI to do this; anything "CQUI" was renamed to "ML", and I removed references to the custom CQUI Citizen Management lens.
  • The updates to the non-English Text XML are not yet part of this PR. I will add them next time I get the chance to do the work on this, sometime over the next few days.
  • In order to allow the settings code to make some assumptions, I did some renaming of objects so their "COLOR" and "LOC_HUD" names aligned
    • for example: "COLOR_FOO_LENS_BAR" will now always have a "LOC_HUD_FOO_LENS_BAR" counterpart.
  • In spite of many files changed, I tried to keep changes as reasonable as I could.
  • Using the "ignore whitespace" option for at least the ML_Settings.xml, as I had to add some controls and it messes with indenting and whatnot.

Notes on Functionality:

  • The values apply on a per-saved game basis, like most settings of this nature.
  • The "default" button reverts a lens color back to the value found in the Color Settings table
  • The updated colors apply when the panel is closed, updating colors immediately (like when moving the scroll bar for a color) was really slow (at least with CQUI, anyway)
  • Once updated the Key will also update (if opened via the Lenses panel)

Pics / Gifs:
image
gif
gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants