Resolve editor-specified config file once #15494
Draft
+105
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
force-pushed
the
dhruv/resolve-config-once
branch
from
9538418 to
42fe0fc
Compare
|
dhruvmanila
force-pushed
the
dhruv/resolve-config-once
branch
from
42fe0fc to
a2b3c62
Compare
|
Hmm, this might not be the correct solution. We'll also need to register the file watcher for the path specified in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the logic for handling
ruff.configurationsetting to read and resolve the path (if specified) once.The main motivation for this is so that we can send a request to the client to show the notification in case there are any failures when processing this setting. Without this change, the notification will be send as many times as the number of config files present in the project.
Closes: #12572
Test Plan