This repository has been archived by the owner on Jun 8, 2024. It is now read-only.
fix(global config): renamed default-config to typstfmt
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to name global config the same way as the local config. This way any local config can quickly become a global config (without renaming the file).
|
Note: We could add an option to let the user provide a config path for testing purposes (but we don't have to, let's wait the need for it first) |
Merged `CONFY_APP_NAME` and `GLOBAL_CONFIG_BASE_NAME` into `APP_NAME`. It is shorter and more meaningful.
|
With your latest change, the file ends up in |
Well, yes, that was the idea.
I was born ready. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to name global config the same way as the local config. This way any local config can quickly become a global config (without renaming the file).