Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Geth 1.14.11 #50

Open
wants to merge 822 commits into
base: main
Choose a base branch
from
Open

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Oct 2, 2024

This PR contains the upgrade to 1.14.11 from 1.14.3

Key Changes:

  1. A new simulate call eth_simulateV1 has been added which allows users to simulate multiple blocks. This can be useful for our auctioneer work.
  2. Fix out of bounds access in json unmarshalling (common/math: fix out of bounds access in json unmarshalling ethereum/go-ethereum#30014) (Copied from the release notes) which is a relevant bug fix for us.
  3. Add missing lock in peer discovery (p2p/discover: add missing lock when calling tab.handleAddNode ethereum/go-ethereum#29960) (Copied from release notes) which is a relevant bug fix for us.

Changes to tests:

  1. We have commented out ExecutionSpecTests and tests which are contained in tests directory. These tests fail because the state roots do not match what is expected. The state roots do not match because we do not burn the base fee and instead we transfer the fee to the fee recipient which changes the state root.
  2. We have commented out tests which launch a simulated geth node using simulatedBackend and submits transactions to it. These tests will fail since transactions are fed into astria-geth via the astria sequencer. We would require a mock astria sequencer which would currently be significant work.

Testing:

Deployed a local cluster and have run eoa, erc20 and univ2tx spamooor scenarios against them successfully.

9547 and others added 30 commits June 6, 2024 10:55
rlp: no need to repeat calling len
Fixes an issue where discovery responses were not recognized.
* cmd/utils, consensus/beacon, core/state: when configured via stub  flag: prefetch all reads from account/storage tries, terminate prefetcher synchronously.

* cmd, core/state: fix nil panic, fix error handling, prefetch nosnap too

* core/state: expand prefetcher metrics for reads and writes separately

* cmd/utils, eth: fix noop collect witness flag

---------

Co-authored-by: Péter Szilágyi <[email protected]>
* .golangci.yml: enable check for consistent receiver name

* beacon/light/sync: fix receiver name

* core/txpool/blobpool: fix receiver name

* core/types: fix receiver name

* internal/ethapi: use consistent receiver name 'api' for handler object

* signer/core/apitypes: fix receiver name

* signer/core: use consistent receiver name 'api' for handler object

* log: fix receiver name
* fix: Optimize regular initialization

* modify var name

* variable change to private types
…rom trie Commit (#29869)

* core/state, eth/protocols, trie, triedb/pathdb:  remove unused error return from trie Commit

* move set back to account-trie-update block scoping for easier readability

* address review

* undo tests submodule change

* trie:  panic if BatchSerialize returns an error in Verkle trie Commit

* trie: verkle comment nitpicks

---------

Co-authored-by: Péter Szilágyi <[email protected]>
* beacon/light/request: add server test for event after unsubscribe

* beacon/light/api: fixed double stream.Close()

* beacon/light/request: add checks for nil event callback function

* beacon/light/request: unlock server mutex while unsubscribing from parent
* upgrade lock usage

* revert unnecessary change
updates some docstrings
---------

Co-authored-by: rjl493456442 <[email protected]>
holiman and others added 27 commits September 26, 2024 08:12
…30506)

This PR fixes two tests, which had a tendency to sometimes write to the `*testing.T` `log` facility after the test function had completed, which is not allowed. This PR fixes it by using waitgroups to ensure that the handler/logwriter terminates before the test exits.

closes #30505
This update should only affect the fuzzers, as far as I know. But it
seems like it might also fix some arm/macos compilation issue in
ethereum/go-ethereum#30494

Closes #30494 (I think)
…rollback (#30495)

Here we move the method that drops all transactions by temporarily increasing the fee
into the TxPool itself. It's better to have it there because we can set it back to the
configured value afterwards. This resolves a TODO in the simulated backend.
core/txpool/blobpool: return all reinject-addresses
…ue upon rollback" (#30521)

Reverts ethereum/go-ethereum#30495

You are free to create a proper Clear method if that's the best way. But
one that does a proper cleanup, not some hacky call to set gas which
screws up logs, metrics and everything along the way. Also doesn't work
for legacy pool local transactions.

The current code had a hack in the simulated code, now we have a hack in
live txpooling code. No, that's not acceptable. I want the live code to
be proper, meaningful API, meaningful comments, meaningful
implementation.
… (#30512)

This is for fixing Prysm integration tests.
Use types.Sender(signer, tx) to utilize the transaction's sender cache
and avoid repeated address recover.
This PR removes the dependencies on `lightchaindata` db as the light
protocol has been deprecated and removed from the codebase.
@bharath-123 bharath-123 marked this pull request as ready for review October 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.