Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make massmappy an installable package #1

Open
wants to merge 5 commits into
base: public
Choose a base branch
from

Conversation

EiffL
Copy link

@EiffL EiffL commented Dec 11, 2017

In its present form, massmappy is not a proper python package. I have modified the setup.py and moved the source files to an isolated massmappy directory so that it can now be installed easily with the following command:

python setup.py install --user

It shouldn't change the previous behavior, you can still compile the files with python setup.py build_ext --inplace command. The scripts in the src/python folder should work just as before.

I have also added a draft jupyter notebook to demonstrate how massmappy can be used, you may want to add documentation and comments to make it nicer.

With these modifications, and the one I have submitted for ssht, the whole astroinformatics software stack can be installed in a docker container and massmappy can be tried live in a jupyter notebook, see https://github.com/EiffL/astro-informatics-docker for more details.

@EiffL
Copy link
Author

EiffL commented Apr 6, 2018

Hi @jasonmcewen any update on that PR ?

@jasonmcewen
Copy link
Contributor

Hi @EiffL, @cgrwallis left academia recently for an industry position, hence the reason the PR hasn't been reviewed and merged. Thanks for pinging us. Matt and I will try to look at it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants