Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmarks #367

Merged
merged 33 commits into from
Dec 13, 2024
Merged

Update benchmarks #367

merged 33 commits into from
Dec 13, 2024

Conversation

tkoskela
Copy link
Contributor

@tkoskela tkoskela commented Nov 8, 2024 •
edited
Loading

Tidies up and adds to algorithm (previously only padmm) benchmarks. Adds a forward backward benchmark and a forward backward + onnx denoiser benchmark. Updated both serial and MPI versions.

tkoskela added 30 commits October 24, 2024 12:12
@tkoskela
Distribute visibilities to get strong scaling benchmarks
ef81d97
@tkoskela
Add warmup time to benchmarks
4a2984d
@tkoskela
Enable debug logging
ccddb82
@tkoskela
Scatter visibilities. Define parameters.
10614a6
@tkoskela
Clean up padmm benchmarks
aa05250
@tkoskela
Use factories in padmm benchmarks
b59fa42
@tkoskela
Merge branch 'tk/mpi_operator_benchmark_strong_scaling' of github.com…
60e1afd 
…:astro-informatics/purify into tk/mpi_operator_benchmark_strong_scaling
@tkoskela
Don't use hard coded paths
86b9c19
@tkoskela
Fix variable names
01e2128
@tkoskela
Add some logging to report where vis data is coming from
f36b91b
@tkoskela
Update measurements the same way as mpi version
645d7f0
@tkoskela
Clarify names, call the right padmm object
06f4732
@tkoskela
Add placeholders to logging command
4e9f982
@tkoskela
Reduce sopt verbosity
73fd8d8
@tkoskela
Fix bugs and lint. Add smaller test for comparison with serial version
e5333f1
@tkoskela
Add info to factory functions
f8ba8c0
@tkoskela
Add FB algorithms, rename to be more descriptive
54ae8dd
@tkoskela
Help purify look up the ONNX runtime
6c539de
@tkoskela
Install data files for TF models
9cab4f0
@tkoskela
Add FB benchmark that uses onnx rt
45d7bb4
@tkoskela
Merge branch 'development' into tk/mpi_operator_benchmark_strong_scaling
206342a
@tkoskela
Linting
1aa8861
@tkoskela
More linting
21ff63f
@tkoskela
Linting++
7677b1f
@tkoskela
One more for the linter
ec1febd
@tkoskela
Merge branch 'development' into tk/mpi_operator_benchmark_strong_scaling
e3385e4
@tkoskela
Remove obsolete reference to notinstalled namespace
16b0fac
@tkoskela
Use correct models directory
2810d43
@tkoskela
remove onnxrt lookup, should be provided by sopt
ad473fc
@tkoskela
Remove duplicate
ed0bfd8
@tkoskela tkoskela marked this pull request as ready for review December 13, 2024 16:21
@tkoskela tkoskela changed the title WIP: Update benchmarks Update benchmarks Dec 13, 2024
@tkoskela tkoskela requested review from mmcleod89 and 20DM December 13, 2024 17:21
20DM
20DM approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@20DM 20DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this! 🚀

@20DM 20DM merged commit 4c86203 into development Dec 13, 2024
14 checks passed
@tkoskela tkoskela deleted the tk/mpi_operator_benchmark_strong_scaling branch February 18, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20DM 20DM 20DM approved these changes

@mmcleod89 mmcleod89 Awaiting requested review from mmcleod89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkoskela @20DM