Fix tcp socket with connect timeout #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library doesn't fully work with Ruby versions > 3
The TCPSocket class in ruby 3.0.0 and up has an optional keyword argument to specify a connection timeout. Another library we were using was passing a
connect_timeout
to the TCPSocket initializer. Because this library monkey patches the initializer and then doesn't allow for additional keyword arguments theconnect_timeout
argument was getting turned into a hash and passed as thelocal_host
argument which caused exceptions.The test (without the code changes in
tcpsocket
replicates the errors it could cause.This change allows for keyword arguments so that a
connect_timeout
can be passed.