Skip to content

Commit

Permalink
Exit instead of return in case of Providers[fab] test is ignored (apa…
Browse files Browse the repository at this point in the history
…che#40089)

The apache#40059 added an exception for fab tests not to run on old
airflow releases but it was wrong doing return instead of exit
  • Loading branch information
potiuk authored Jun 6, 2024
1 parent 42a2b1a commit 0568e9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ function determine_airflow_to_use() {
echo
echo "${COLOR_YELLOW}Skipping FAB tests on Airflow 2.7 and 2.8 because of FAB incompatibility with them${COLOR_RESET}"
echo
return
exit 0
fi
python "${IN_CONTAINER_DIR}/install_airflow_and_providers.py"
# Some packages might leave legacy typing module which causes test issues
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/entrypoint_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ function determine_airflow_to_use() {
echo
echo "${COLOR_YELLOW}Skipping FAB tests on Airflow 2.7 and 2.8 because of FAB incompatibility with them${COLOR_RESET}"
echo
return
exit 0
fi
python "${IN_CONTAINER_DIR}/install_airflow_and_providers.py"
# Some packages might leave legacy typing module which causes test issues
Expand Down

0 comments on commit 0568e9a

Please sign in to comment.