minor FastAPI tests fixes (apache#44429)

* fix dag_run test

* fix trailing / from tests

* revert comments

* Update tests/api_fastapi/core_api/routes/public/test_plugins.py

tests/api_fastapi/core_api/routes/public/test_config.py

@@ -265,9 +265,9 @@ def test_get_config(self, test_client, section, headers, expected_status_code, e
         query_params = {"section": section} if section else None
         if expected_status_code == 403:
             with conf_vars(AIRFLOW_CONFIG_DISABLE_EXPOSE_CONFIG):
-                response = test_client.get("/public/config/", headers=headers, params=query_params)
+                response = test_client.get("/public/config", headers=headers, params=query_params)
         else:
-            response = test_client.get("/public/config/", headers=headers, params=query_params)
+            response = test_client.get("/public/config", headers=headers, params=query_params)
         self._validate_response(headers, expected_response, expected_status_code, response)
 
     @pytest.mark.parametrize(
@@ -300,7 +300,7 @@ def test_get_config_non_sensitive_only(
         self, test_client, headers, expected_status_code, expected_response
     ):
         with conf_vars(AIRFLOW_CONFIG_NON_SENSITIVE_ONLY_CONFIG):
-            response = test_client.get("/public/config/", headers=headers)
+            response = test_client.get("/public/config", headers=headers)
         self._validate_response(headers, expected_response, expected_status_code, response)
 
 

tests/api_fastapi/core_api/routes/public/test_connections.py

@@ -171,7 +171,7 @@ def test_should_respond_200(
         self, test_client, session, query_params, expected_total_entries, expected_ids
     ):
         self.create_connections()
-        response = test_client.get("/public/connections/", params=query_params)
+        response = test_client.get("/public/connections", params=query_params)
         assert response.status_code == 200
 
         body = response.json()
@@ -200,7 +200,7 @@ class TestPostConnection(TestConnectionEndpoint):
         ],
     )
     def test_post_should_respond_200(self, test_client, session, body):
-        response = test_client.post("/public/connections/", json=body)
+        response = test_client.post("/public/connections", json=body)
         assert response.status_code == 201
         connection = session.query(Connection).all()
         assert len(connection) == 1
@@ -215,7 +215,7 @@ def test_post_should_respond_200(self, test_client, session, body):
         ],
     )
     def test_post_should_respond_400_for_invalid_conn_id(self, test_client, body):
-        response = test_client.post("/public/connections/", json=body)
+        response = test_client.post("/public/connections", json=body)
         assert response.status_code == 400
         connection_id = body["connection_id"]
         assert response.json() == {
@@ -230,10 +230,10 @@ def test_post_should_respond_400_for_invalid_conn_id(self, test_client, body):
         ],
     )
     def test_post_should_respond_already_exist(self, test_client, body):
-        response = test_client.post("/public/connections/", json=body)
+        response = test_client.post("/public/connections", json=body)
         assert response.status_code == 201
         # Another request
-        response = test_client.post("/public/connections/", json=body)
+        response = test_client.post("/public/connections", json=body)
         assert response.status_code == 409
         assert response.json() == {
             "detail": f"Connection with connection_id: `{TEST_CONN_ID}` already exists",
@@ -293,7 +293,7 @@ def test_post_should_respond_already_exist(self, test_client, body):
         ],
     )
     def test_post_should_response_201_redacted_password(self, test_client, body, expected_response):
-        response = test_client.post("/public/connections/", json=body)
+        response = test_client.post("/public/connections", json=body)
         assert response.status_code == 201
         assert response.json() == expected_response
 

tests/api_fastapi/core_api/routes/public/test_dag_run.py

@@ -616,7 +616,7 @@ def test_limit_and_offset(self, test_client, post_body, expected_dag_id_order):
                 ],
             ),
             (
-                {"page_limit": -1, "offset": 1},
+                {"page_limit": -1, "page_offset": 1},
                 [
                     {
                         "type": "greater_than_equal",

tests/api_fastapi/core_api/routes/public/test_event_logs.py

@@ -297,7 +297,7 @@ class TestGetEventLogs(TestEventLogsEndpoint):
     def test_get_event_logs(
         self, test_client, query_params, expected_status_code, expected_total_entries, expected_events
     ):
-        response = test_client.get("/public/eventLogs/", params=query_params)
+        response = test_client.get("/public/eventLogs", params=query_params)
         assert response.status_code == expected_status_code
         if expected_status_code != 200:
             return

tests/api_fastapi/core_api/routes/public/test_plugins.py

@@ -56,7 +56,7 @@ class TestGetConnections:
     def test_should_respond_200(
         self, test_client, session, query_params, expected_total_entries, expected_names
     ):
-        response = test_client.get("/public/plugins/", params=query_params)
+        response = test_client.get("/public/plugins", params=query_params)
         assert response.status_code == 200
 
         body = response.json()

tests/api_fastapi/core_api/routes/public/test_pools.py

@@ -120,7 +120,7 @@ def test_should_respond_200(
         self, test_client, session, query_params, expected_total_entries, expected_ids
     ):
         self.create_pools()
-        response = test_client.get("/public/pools/", params=query_params)
+        response = test_client.get("/public/pools", params=query_params)
         assert response.status_code == 200
 
         body = response.json()
@@ -324,7 +324,7 @@ class TestPostPool(TestPoolsEndpoint):
     def test_should_respond_200(self, test_client, session, body, expected_status_code, expected_response):
         self.create_pools()
         n_pools = session.query(Pool).count()
-        response = test_client.post("/public/pools/", json=body)
+        response = test_client.post("/public/pools", json=body)
         assert response.status_code == expected_status_code
 
         assert response.json() == expected_response
@@ -365,11 +365,11 @@ def test_should_response_409(
     ):
         self.create_pools()
         n_pools = session.query(Pool).count()
-        response = test_client.post("/public/pools/", json=body)
+        response = test_client.post("/public/pools", json=body)
         assert response.status_code == first_expected_status_code
         assert response.json() == first_expected_response
         assert session.query(Pool).count() == n_pools + 1
-        response = test_client.post("/public/pools/", json=body)
+        response = test_client.post("/public/pools", json=body)
         assert response.status_code == second_expected_status_code
         assert response.json() == second_expected_response
         assert session.query(Pool).count() == n_pools + 1

tests/api_fastapi/core_api/routes/public/test_variables.py

@@ -157,7 +157,7 @@ def test_should_respond_200(
         self, session, test_client, query_params, expected_total_entries, expected_keys
     ):
         self.create_variables()
-        response = test_client.get("/public/variables/", params=query_params)
+        response = test_client.get("/public/variables", params=query_params)
 
         assert response.status_code == 200
         body = response.json()
@@ -298,6 +298,6 @@ class TestPostVariable(TestVariableEndpoint):
     )
     def test_post_should_respond_201(self, test_client, session, body, expected_response):
         self.create_variables()
-        response = test_client.post("/public/variables/", json=body)
+        response = test_client.post("/public/variables", json=body)
         assert response.status_code == 201
         assert response.json() == expected_response