This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Editing pass on README.md #43
Open
jwitz
wants to merge
2
commits into
astronomer:main
Choose a base branch
from
jwitz:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too late to rename these transfer types / is this the common term for this type of transfer? This was unintuitive to me, because I considered a worker-driven transfer to be native, but from the perspective that it's native to Airflow. I'd prefer if we called these:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwitz
worker_transfer
makes senseBut
dataset_transfer
doesn't make sense to me. Can you elaborate on this, please? I still feel thatnative
transfers signify natively transferring without involving the worker node. Open to suggestions for better naming for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwitz I think we can still rename these transfers, as we have not done a major release yet.
IMO,
Also, maybe we can lose the
transfer
from names since we already call themtransfer modes
.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO - we should rename them to the below to be more easily understood by users:
1."local"
2."optimized"
3."third-party"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure "optimized" will help users understand exactly what's going on. Optimized can mean many things, and some might consider third party to be the "optimized" solution for their use case.
I like "peer-to-peer" or "direct" @sunank200 !
@utkarsharma2 I think we should still keep "Transfer", because it helps us communicate what these modes are in documentation. If you want to remove "transfer" at the code level in terms of how people specify these modes in the operator parameters, I think that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwitz Sure we can keep the
transfer
in docs, but we can remove it from the code. @sunank200 @phanikumv WDYT?Also, if the choice is between peer-to-peer and direct, I prefer
peer-to-peer
since it's a well known concept, and would be obvious to users.