feat(api): MultiQueryRetriever with WeaviateHybridSearchRetriever #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a0e9816
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c2ded61.ask-astro.pages.dev |
| Branch Preview URL: | https://change-number-of-doc.ask-astro.pages.dev |
|
@Lee-W Now that we have We should try the following:
Let me know if you need any you need to connect on this, please |
sunank200
force-pushed
the
hybrid-search
branch
from
3eba162 to
a2f5ffe
Compare
jlaneve
reviewed
Nov 20, 2023
|
|
||
| from ask_astro.clients.weaviate_ import docsearch |
There was a problem hiding this comment.
sunank200
force-pushed
the
hybrid-search
branch
2 times, most recently
from
d25c8f6 to
3430a16
Compare
sunank200
changed the title
sunank200
force-pushed
the
hybrid-search
branch
from
3430a16 to
80be59f
Compare
tested with 6. a bit better but might have room to improve
not yet have time to work on it today. will continue work on it early tomorrow |
sunank200
force-pushed
the
hybrid-search
branch
from
a0e9816 to
0f0f8d0
Compare
|
close this one, as changes included in #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contradict to our earlier discussion; I suspect what we want to replace
WeaviateHybridSearchRetrieverwith isMultiQueryRetrieverinstead ofConversationalRetrievalChain. However, it seems to perform even worse than theMultiQueryRetrieverwhen it comes to what is astro python sdk?. astronomer-providers, airflow things seem to work. For testing, we can use the same set of env var and the exact same way to bring up the test env locally.