Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config for github actions #1786

Merged
merged 11 commits into from
Feb 22, 2023
Merged

Add CI config for github actions #1786

merged 11 commits into from
Feb 22, 2023

Conversation

utkarsharma2
Copy link
Collaborator

Description

What is the current behavior?

Currently, we are not running any steps in CI for UTO

closes: #1724

What is the new behavior?

We added the GitHub actions config needed for CI to run Tests

Does this introduce a breaking change?

Nope

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 93.76% // Head: 45.22% // Decreases project coverage by -48.55% ⚠️

Coverage data is based on head (f464b13) compared to base (3610312).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    astronomer/astro-sdk#1786       +/-   ##
===========================================
- Coverage   93.76%   45.22%   -48.55%     
===========================================
  Files          93       25       -68     
  Lines        4937      973     -3964     
  Branches      486       90      -396     
===========================================
- Hits         4629      440     -4189     
- Misses        219      524      +305     
+ Partials       89        9       -80     
Impacted Files Coverage Δ
...ersal_transfer_operator/data_providers/__init__.py 100.00% <100.00%> (ø)
sql-cli/sql_cli/settings.py
sql-cli/sql_cli/constants.py
sql-cli/sql_cli/cli/config.py
python-sdk/src/astro/table.py
python-sdk/src/astro/sql/table.py
python-sdk/src/astro/files/types/csv.py
sql-cli/sql_cli/project.py
...dk/src/astro/sql/operators/export_table_to_file.py
python-sdk/src/astro/databases/databricks/delta.py
... and 109 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of labelling UTO PRs in a similar way to what we do with SQL CLI ones?
https://github.com/astronomer/astro-sdk/blob/main/.github/labeler.yml

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utkarsharma2, as we discussed, I'm happy for us to have separate tickets/PRs for fixing the following checks:

  • Fix type check
  • Code coverage

I'm happy for the PR to be merged once Deep Source and the other checks pass.

@utkarsharma2
Copy link
Collaborator Author

@utkarsharma2 utkarsharma2 merged commit 0550e7d into main Feb 22, 2023
@utkarsharma2 utkarsharma2 deleted the CI-UTO branch February 22, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test and CI pipeline for universal transfer operator
2 participants