-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions job for the creating/terminating databricks cluster #2043
base: main
Are you sure you want to change the base?
Conversation
2d19571
to
7265900
Compare
5842697
to
ea43e4e
Compare
@phanikumv @tatiana We're now testing bringing up the databricks cluster and then terminating it after the tests. Could you please help us set up |
I just added the secret, @Lee-W ! |
fc7576f
to
29052b1
Compare
df5c262
to
7b9730d
Compare
7b9730d
to
839f25c
Compare
839f25c
to
1ed8cb0
Compare
Thanks @tatiana ! After a few tests, I found out we might need an extra secret here. Already DM you the secret. Could you please help us set it up? Thanks |
Hi @Lee-W , I just added it - thank you very much for working on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lee-W this ticket is hard work 😬
Please ping us when the tests are passing so we can merge it!
The next thing I'll try is make the secrets small strings instead of the whole json. It seems structured data as json is not recommended by github https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#naming-your-secrets |
Description
What is the current behavior?
run databricks testing on an existing cluster
What is the new behavior?
In this PR, I also unify the yaml style in
.github
. The main changes live in the first and the third commitDoes this introduce a breaking change?
no
Checklist