Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues related to the GitHub action upload-artifact #2188

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix CI issues related to the GitHub action upload-artifact #2188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac22ca8
Fix CI issues
tatiana Sep 20, 2024
a5471f0
Temporary change to CI so we can see the changes in the current branc…
tatiana Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions .github/workflows/ci-python-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
name: Build and test astro Python SDK
on:
push:
branches: [ 'main', 'release-**' ]
branches: [ 'main', 'release-**', 'fix-ci' ]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: [ 'main', 'release-**', 'fix-ci' ]
branches: [ 'main', 'release-**' ]

paths:
- 'python-sdk/**'
- '.github/workflows/ci-python-sdk.yaml'
Comment on lines 6 to 7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'python-sdk/**'
- '.github/workflows/ci-python-sdk.yaml'
- 'python-sdk/**'
- '.github/workflows/ci-python-sdk.yaml'
pull_request:
branches: [ 'main', 'release-**' ]
paths:
- 'python-sdk/**'
- '.github/workflows/ci-python-sdk.yaml'
- '*'

pull_request:
branches: [ 'main', 'release-**' ]
paths:
- 'python-sdk/**'
- '.github/workflows/ci-python-sdk.yaml'
- '*'
# Run on PRs from forks
pull_request_target:
branches: [ 'main' ]
Expand Down Expand Up @@ -193,10 +187,11 @@ jobs:
- run: pip3 install nox
- run: nox -s test_examples_by_dependency -- --cov=src --cov-report=xml --cov-branch
- name: Upload coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage${{ matrix.group }}
path: ./python-sdk/.coverage
include-hidden-files: true
env:
GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }}
GOOGLE_APPLICATION_CREDENTIALS: /tmp/google_credentials.json
Expand Down Expand Up @@ -258,10 +253,11 @@ jobs:
- run: pip3 install nox
- run: nox -s "test-${{ matrix.version }}(airflow='2.8')" -- tests/ --cov=src --cov-report=xml --cov-branch
- name: Upload coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-unit-test
path: ./python-sdk/.coverage
include-hidden-files: true

Run-load-file-Integration-Airflow-2-8:
if: >-
Expand Down Expand Up @@ -339,15 +335,17 @@ jobs:
- run: nox -s "test-3.10(airflow='2.8')" -- tests_integration/ -k "test_load_file.py and not redshift" --splits 3 --group ${{ matrix.group }} --store-durations --durations-path /tmp/durations-${{ matrix.group }} --cov=src --cov-report=xml --cov-branch
- run: cat /tmp/durations-${{ matrix.group }}
- name: Upload coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.group }}-integration-tests
path: ./python-sdk/.coverage
include-hidden-files: true
- name: Collect pytest durations
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: pytest_durations_load_file_${{ matrix.group }}
path: /tmp/durations-${{ matrix.group }}
include-hidden-files: true
env:
GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }}
GOOGLE_APPLICATION_CREDENTIALS: /tmp/google_credentials.json
Expand Down Expand Up @@ -440,15 +438,17 @@ jobs:
- run: nox -s "test-3.10(airflow='2.8')" -- tests_integration/ -k "test_example_dags.py and not redshift" --splits 3 --group ${{ matrix.group }} --store-durations --durations-path /tmp/durations-${{ matrix.group }} --cov=src --cov-report=xml --cov-branch
- run: cat /tmp/durations-${{ matrix.group }}
- name: Upload coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.group }}-integration-tests
path: ./python-sdk/.coverage
include-hidden-files: true
- name: Collect pytest durations
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: pytest_durations_example_dags_${{ matrix.group }}
path: /tmp/durations-${{ matrix.group }}
include-hidden-files: true
env:
GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }}
GOOGLE_APPLICATION_CREDENTIALS: /tmp/google_credentials.json
Expand Down Expand Up @@ -541,15 +541,16 @@ jobs:
- run: nox -s "test-3.10(airflow='2.8')" -- tests_integration/ -k "not test_load_file.py and not test_example_dags.py and not redshift" --splits 11 --group ${{ matrix.group }} --store-durations --durations-path /tmp/durations-${{ matrix.group }} --cov=src --cov-report=xml --cov-branch
- run: cat /tmp/durations-${{ matrix.group }}
- name: Upload coverage
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.group }}-integration-tests
path: ./python-sdk/.coverage
- name: Collect pytest durations
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: pytest_durations_integration_tests_${{ matrix.group }}
path: /tmp/durations-${{ matrix.group }}
include-hidden-files: true
env:
GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }}
GOOGLE_APPLICATION_CREDENTIALS: /tmp/google_credentials.json
Expand Down Expand Up @@ -601,6 +602,7 @@ jobs:
name: constraints-${{ matrix.python }}-${{ matrix.airflow }}
path: ./python-sdk/constraints-${{ matrix.python }}-${{ matrix.airflow }}
if-no-files-found: error
include-hidden-files: true

Code-Coverage:
if: github.event.action != 'labeled'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed some tests failed due to uploading artefacts with the same name; this has to be addressed before we merge this PR. This project thas not been actively maintained for a while, so we may uncover other issues before this PR can be merged.

Expand Down
Loading