Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate microsoft async provider #1412

Closed
4 tasks done
Lee-W opened this issue Jan 2, 2024 · 9 comments · Fixed by #1437
Closed
4 tasks done

Deprecate microsoft async provider #1412

Lee-W opened this issue Jan 2, 2024 · 9 comments · Fixed by #1437
Assignees
@pankajkoti
Labels
feature New feature or request
Milestone
1.19.0

Comments

@Lee-W
Copy link
Contributor

Lee-W commented Jan 2, 2024 •
edited by pankajkoti
Loading

Is your feature request related to a problem? Please describe.

as most of the functionality has been contributed back to OSS airflow, we're going to leverage the code there and deprecate this project

Describe the solution you'd like

  1. Contribute the delta to the OSS provider
  2. Point the astronomer provider to the OSS provider
  3. Do the release and wait for a month or so before we remove the astronomer provider in a major release

Describe alternatives you've considered

Additional context

Current Progress

  • Number of operator changes on OSS airflow needed: 1 (finished: 1)
  • Number of operators/sensors to deprecate: 4 (finished: 1, In review: 2, On hold: 1)
  1. AzureDataFactoryPipelineRunStatusSensorAsync
  2. WasbBlobSensorAsync
  3. WasbPrefixSensorAsync
  4. AzureDataFactoryRunPipelineOperatorAsync
@Lee-W Lee-W added the feature New feature or request label Jan 2, 2024
@Lee-W Lee-W added this to the 2.0.0 milestone Jan 2, 2024
@Lee-W Lee-W self-assigned this Jan 2, 2024
@Lee-W Lee-W changed the title Drepcreate microsoft provider Deprecate microsoft async provider Jan 2, 2024
@phanikumv
Copy link
Collaborator

Can you work on this one @pankajkoti ?

@phanikumv phanikumv assigned pankajkoti and unassigned Lee-W Jan 16, 2024
@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 17, 2024

As of Jan 17th

  • Deprecation PR needed
    • AzureDataFactoryPipelineRunStatusSensorAsync
    • WasbBlobSensorAsync
    • AzureDataFactoryRunPipelineOperatorAsync
  • Wait for the upstream release (Deprecation PR afterward)
    • WasbPrefixSensorAsync

@pankajkoti This is the current progress of this PR

@pankajkoti
Copy link
Collaborator

Thank you @Lee-W for the details and the sync-up call. I am starting on this one today

pankajkoti added a commit that referenced this issue Jan 18, 2024
@pankajkoti
Deprecate AzureDataFactoryRunPipelineOperatorAsync
c528599 
Deprecate AzureDataFactoryRunPipelineOperatorAsync and proxy it to
its Airflow OSS provider's counterpart

related: #1412
@pankajkoti pankajkoti mentioned this issue Jan 18, 2024
Merged
@pankajkoti
Copy link
Collaborator

pankajkoti commented Jan 19, 2024 •
edited
Loading

Create PR 1 for AzureDataFactoryRunPipelineOperatorAsync #1431

Left a comment on the OSS provider PR worked upon for WasbPrefixSensorAsync

Will work today on next items in the checklist

@phanikumv phanikumv modified the milestones: 2.0.0, 1.19.0 Jan 19, 2024
pankajkoti added a commit that referenced this issue Jan 19, 2024
@pankajkoti
Deprecate WasbBlobSensorAsync
a060fd7 
Deprecate WasbBlobSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
@pankajkoti pankajkoti mentioned this issue Jan 19, 2024
Merged
@pankajkoti
Copy link
Collaborator

Created PR 2 for Deprecate WasbBlobSensorAsync #1435

pankajkoti added a commit that referenced this issue Jan 19, 2024
@pankajkoti
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync
b252dbc 
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync and proxy it
to its Airflow OSS provider's counterpart

related: #1412
@pankajkoti pankajkoti mentioned this issue Jan 19, 2024
Merged
pankajkoti added a commit that referenced this issue Jan 19, 2024
@pankajkoti
Deprecate WasbBlobSensorAsync (#1435)
52aaa36 
Deprecate WasbBlobSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 19, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
ebe50bd 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 19, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
f7c4fed 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
@pankajkoti pankajkoti mentioned this issue Jan 19, 2024
Merged
@pankajkoti
Copy link
Collaborator

Created PR 3 #1436
and
Created PR 4 #1437

pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync
98edef8 
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync and proxy it
to its Airflow OSS provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate AzureDataFactoryRunPipelineOperatorAsync
6ad0a03 
Deprecate AzureDataFactoryRunPipelineOperatorAsync and proxy it to
its Airflow OSS provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync (#1436)
4f02e6a 
Deprecate AzureDataFactoryPipelineRunStatusSensorAsync and proxy it
to its Airflow OSS provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate AzureDataFactoryRunPipelineOperatorAsync
5304103 
Deprecate AzureDataFactoryRunPipelineOperatorAsync and proxy it to
its Airflow OSS provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
d6ec333 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
1f7ae36 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate AzureDataFactoryRunPipelineOperatorAsync (#1431)
db37a2d 
Deprecate AzureDataFactoryRunPipelineOperatorAsync and proxy it to
its Airflow OSS provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
82b9cec 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Jan 22, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
0480fe6 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
@phanikumv
Copy link
Collaborator

Waiting for OSS release

pankajkoti added a commit that referenced this issue Jan 30, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
1788c66 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
@pankajkoti
Copy link
Collaborator

pankajkoti commented Jan 31, 2024 •
edited
Loading

Based on our request, Elad has kindly created an RC specifically for Azure provider yesterday night . I will test it out today.

pankajkoti added a commit that referenced this issue Jan 31, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
8590212 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
@pankajkoti
Copy link
Collaborator

Voting is in progress for the RC(1 more binding vote needed), hopefully would be released tonight/tomorrow morning.

pankajkoti added a commit that referenced this issue Feb 4, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync
e24e992 
Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

related: #1412
pankajkoti added a commit that referenced this issue Feb 4, 2024
@pankajkoti
Deprecate WasbPrefixSensorAsync (#1437)
f6d09ad 
* Deprecate WasbPrefixSensorAsync

Deprecate WasbPrefixSensorAsync and proxy it to its Airflow OSS
provider's counterpart

closes: #1412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankajkoti pankajkoti

Labels
feature New feature or request
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Deprecate WasbPrefixSensorAsync astronomer/astronomer-providers
3 participants
@Lee-W @pankajkoti @phanikumv